-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Add analytics platform to esphome #153311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analytics platform to esphome #153311
Conversation
|
Hey there @jesserockz, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds analytics platform support to the ESPHome integration to disable extended analytics collection for ESPHome devices. The change prevents Home Assistant from collecting detailed analytics data for custom ESPHome devices, which are user-created and not of interest for analytics purposes.
Key changes:
- Implements analytics platform that disables extended analytics for the entire ESPHome integration
- Adds comprehensive test coverage to verify the analytics exclusion functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/esphome/analytics.py |
New analytics platform implementation that returns AnalyticsModifications(remove=True) to disable analytics |
tests/components/esphome/test_analytics.py |
Test suite verifying that ESPHome devices are excluded from analytics payload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @arturpragacz 👍
../Frenck
Proposed change
Add analytics platform to esphome.
The platform will disable extended analytics for the whole esphome integration.
ESPHome project is utilised by users to create custom devices, which we are not interested in.
We want to revisit this in the future, in so far as to selectively allow devices from some known manufacturers.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: