Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Aug 8, 2021

Proposed change

  • RFC Compliance: Responses are now aggregated when possible per rules in RFC6762 section 6.4

  • Bugfix: Responses that trigger the protection against against excessive packet flooding due to software bugs or malicious attack described in RFC6762 section 6 are delayed instead of discarding as it was causing responders that implement Passive Observation Of Failures (POOF) to evict the records. This will cause HomeKit bridges to drop the connection

  • Bugfix: Probe responses are now always sent immediately as there were cases where they would fail to be answered in time to defend a name.

  • Bugfix: Ensure multicast aggregation sends responses within 620ms

  • Bugfix: Timing adjustments to ensure that answers are sent within the default 3000ms timeout for ServiceInfo

Changelog: python-zeroconf/python-zeroconf@0.33.4...0.34.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- RFC Compliance: Responses are now aggregated when possible per rules in RFC6762 section 6.4

- Bugfix: Responses that trigger the protection against against excessive packet flooding due to software bugs or malicious attack described in RFC6762 section 6 are delayed instead of discarding as it was causing responders that implement Passive Observation Of Failures (POOF) to evict the records. This could cause HomeKit bridges to drop the connection

- Bugfix: Probe responses are now always sent immediately as there were cases where they would fail to be answered in time to defend a name.

Changelog: python-zeroconf/python-zeroconf@0.33.4...0.34.0
@bdraco bdraco added this to the 2021.8.5 milestone Aug 8, 2021
@bdraco bdraco marked this pull request as draft August 9, 2021 00:00
@bdraco
Copy link
Member Author

bdraco commented Aug 9, 2021

I found another case were the response could be delayed too long. I'm going to write a test and fix that and bump to 0.34.1

@bdraco bdraco changed the title Bump zeroconf to 0.34.0 Bump zeroconf to 0.34.1 Aug 9, 2021
@bdraco
Copy link
Member Author

bdraco commented Aug 9, 2021

After watching packets, I can make this a bit more efficient. I've got a tiny change I want to make and will push an 0.34.2

@bdraco bdraco changed the title Bump zeroconf to 0.34.1 Bump zeroconf to 0.34.2 Aug 9, 2021
@bdraco bdraco changed the title Bump zeroconf to 0.34.2 Bump zeroconf to 0.34.3 Aug 9, 2021
@bdraco
Copy link
Member Author

bdraco commented Aug 9, 2021

I'm going to let my torture tests for this run overnight in a loop just to make sure everything is solid.

@bdraco bdraco marked this pull request as ready for review August 9, 2021 12:48
@frenck frenck merged commit f37b164 into home-assistant:dev Aug 9, 2021
balloob pushed a commit that referenced this pull request Aug 10, 2021
@balloob balloob mentioned this pull request Aug 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants