-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Bump zeroconf to 0.34.3 #54294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bump zeroconf to 0.34.3 #54294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RFC Compliance: Responses are now aggregated when possible per rules in RFC6762 section 6.4 - Bugfix: Responses that trigger the protection against against excessive packet flooding due to software bugs or malicious attack described in RFC6762 section 6 are delayed instead of discarding as it was causing responders that implement Passive Observation Of Failures (POOF) to evict the records. This could cause HomeKit bridges to drop the connection - Bugfix: Probe responses are now always sent immediately as there were cases where they would fail to be answered in time to defend a name. Changelog: python-zeroconf/python-zeroconf@0.33.4...0.34.0
|
I found another case were the response could be delayed too long. I'm going to write a test and fix that and bump to 0.34.1 |
|
After watching packets, I can make this a bit more efficient. I've got a tiny change I want to make and will push an 0.34.2 |
|
I'm going to let my torture tests for this run overnight in a loop just to make sure everything is solid. |
frenck
approved these changes
Aug 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cherry-picked
cla-signed
core
dependency-bump
integration: zeroconf
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
RFC Compliance: Responses are now aggregated when possible per rules in RFC6762 section 6.4
Bugfix: Responses that trigger the protection against against excessive packet flooding due to software bugs or malicious attack described in RFC6762 section 6 are delayed instead of discarding as it was causing responders that implement Passive Observation Of Failures (POOF) to evict the records. This will cause HomeKit bridges to drop the connection
Bugfix: Probe responses are now always sent immediately as there were cases where they would fail to be answered in time to defend a name.
Bugfix: Ensure multicast aggregation sends responses within 620ms
Bugfix: Timing adjustments to ensure that answers are sent within the default 3000ms timeout for ServiceInfo
Changelog: python-zeroconf/python-zeroconf@0.33.4...0.34.3
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: