Skip to content
This repository was archived by the owner on Feb 27, 2023. It is now read-only.

Conversation

rosskukulinski
Copy link
Contributor

If a user follows our docs and tries to create a k8s discoverer secret with a different filename than config, the deployment will fail.

This PR explicitly specifies the Secret key to be config, regardless of which filename the kubeconfig data is in.

Signed-off-by: Ross Kukulinski [email protected]

@rosskukulinski rosskukulinski requested a review from alexbrand May 16, 2018 20:22
@rosskukulinski rosskukulinski added this to the v0.2 milestone May 16, 2018
Copy link
Contributor

@alexbrand alexbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbrand alexbrand merged commit e1aed0f into master May 16, 2018
@alexbrand alexbrand deleted the discovery-secret-doc branch May 16, 2018 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants