build(deps): Bump the github-actions group with 2 updates #1217
Conversation
Bumps the github-actions group with 2 updates: [miniscruff/changie-action](https://github.com/miniscruff/changie-action) and [actions/setup-go](https://github.com/actions/setup-go). Updates `miniscruff/changie-action` from 2.0.0 to 2.1.0 - [Release notes](https://github.com/miniscruff/changie-action/releases) - [Changelog](https://github.com/miniscruff/changie-action/blob/main/CHANGELOG.md) - [Commits](miniscruff/changie-action@6dcc253...5036dff) Updates `actions/setup-go` from 5.5.0 to 6.0.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@d35c59a...4469467) --- updated-dependencies: - dependency-name: miniscruff/changie-action dependency-version: 2.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: actions/setup-go dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]>
882d34c to
0e172a3
Compare
0e172a3 to
0028da9
Compare
There was a problem hiding this comment.
Left some thoughts!
Since we're just upgrading the Go version here, we should also:
- Bump the
toolsGo module - Add a changelog, since this is a Go module and our next release would require Go 1.24 to be used
Reference for the last time we bumped this module -> #1114
go.mod
Outdated
| go 1.23.0 | ||
|
|
||
| toolchain go1.23.7 | ||
| go 1.24.4 |
There was a problem hiding this comment.
Unless Go's dependency chain logic has changed, this should be 1.24.0, so that the next version of terraform-plugin-framework works with all patch versions of 1.24.x, instead of just 1.24.4 and latest. The toolchain can be the latest at the moment, since it just affects our development environment.
The go get command is a little finicky with this, so you kind of have to coerce it to have the correct versions:
# Allow all patch versions of 1.24
go get [email protected]
go mod tidy
go fix ./...
cd tools
# Not externally consumed, can just use latest
go get [email protected]
go mod tidyThis was a lesson we learned recently when Go introduced the new toolchain directive: #1042
For any executables or modules not consumed externally (like the tools module, providers, plugin-docs), we can just do the latest Go version.
b24c00e to
5ef1a9d
Compare
| go 1.24.0 | ||
|
|
||
| toolchain go1.24.4 |
There was a problem hiding this comment.
Similar comment to hashicorp/terraform-plugin-go#556 (comment), but not a blocker 👍🏻
Bumps the github-actions group with 2 updates: miniscruff/changie-action and actions/setup-go.
Updates
miniscruff/changie-actionfrom 2.0.0 to 2.1.0Release notes
Sourced from miniscruff/changie-action's releases.
Changelog
Sourced from miniscruff/changie-action's changelog.
Commits
5036dffsupport install only and custom work dir (#302)a6093f5Bump the node-deps group with 3 updates (#299)a78ca2bBump the node-deps group with 3 updates (#298)07f1ae3Bump actions/checkout from 4 to 5 in the action-deps group (#297)2c1effcBump the node-deps group with 3 updates (#296)fc96aa3Bump the node-deps group with 8 updates (#295)983f75aBump the node-deps group across 1 directory with 8 updates (#293)59c7589Bump the node-deps group with 6 updates (#290)e9b8ae5Bump the node-deps group with 8 updates (#289)25e3d52Bump the node-deps group with 6 updates (#288)Updates
actions/setup-gofrom 5.5.0 to 6.0.0Release notes
Sourced from actions/setup-go's releases.
Commits
4469467Bump actions/checkout from 4 to 5 (#631)e093d1eNode 24 upgrade (#624)1d76b95Improve toolchain handling (#460)e75c3e8Bumpform-datato bring in fix for critical vulnerability (#618)8e57b58Bump eslint-plugin-jest from 28.11.0 to 29.0.1 (#603)7c0b336Bump typescript from 5.4.2 to 5.8.3 (#538)6f26dccBump undici from 5.28.5 to 5.29.0 (#594)8d4083aBump@typescript-eslint/parserfrom 5.62.0 to 8.32.0 (#590)fa96338Bump@actions/tool-cachefrom 2.0.1 to 2.0.2 (#591)4de67c0Bump@types/jestfrom 29.5.12 to 29.5.14 (#589)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions