Skip to content

Conversation

stephybun
Copy link
Member

Description

  • Extends ConfigureResponse to support ListResourceData
  • Copies ListResourceData over in the ConfigureProvider RPC call

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Nerp

@stephybun stephybun requested a review from a team as a code owner August 13, 2025 07:37
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 🚀 , one nit is we should probably add a quick test (can be in a future PR if you prefer)

"response-actiondata": {
server: &fwserver.Server{
Provider: &testprovider.Provider{
SchemaMethod: func(_ context.Context, _ provider.SchemaRequest, resp *provider.SchemaResponse) {},
ConfigureMethod: func(ctx context.Context, req provider.ConfigureRequest, resp *provider.ConfigureResponse) {
resp.ActionData = "test-provider-configure-value"
},
},
},
request: &provider.ConfigureRequest{},
expectedResponse: &provider.ConfigureResponse{
ActionData: "test-provider-configure-value",
},
},

@gdavison
Copy link

Confirmed that this works

@stephybun
Copy link
Member Author

I need to add another configure related test for the list resource call in fwserver, I'll lump those together in a separate PR

@stephybun stephybun merged commit 3a3e409 into main Aug 14, 2025
69 of 72 checks passed
@stephybun stephybun deleted the f/add-list-resource-data branch August 14, 2025 06:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2025
@austinvalle austinvalle added this to the v1.16.0 milestone Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants