action: Add initial schema interface, attributes, and unlinked schema #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
commented
Jul 11, 2025
Comment on lines
+18
to
+20
| // UnlinkedSchema defines the structure and value types of an unlinked action. An unlinked action | ||
| // cannot cause changes to resource state. | ||
| type UnlinkedSchema struct { |
There was a problem hiding this comment.
This is where the 3 schema types will differ (and the reason for using an interface instead of a single struct type), so they can introduce specific schema info for each type. Unlinked doesn't actually have any additional info needed, but linked/lifecycle will need information about their linked resources and lifecycle will need an execution order.
SBGoods
approved these changes
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A
Description
This PR hooks up the
GetProviderSchemaandGetMetadataRPCs and implements the unlinked action schema (along with a couple attributes).Notes
proto5serverandproto6servertests, I deleted a ton of duplicate tests. Those tests don't add a ton of value on their own and the schema ones in particular are annoying to update 😆 (perhaps more cleanup/consolidation can come in the future)Rollback Plan
Changes to Security Controls
No