Skip to content

When a filename's attachment contains a percent there is an URI malformed error #1835

@tristanrobert

Description

@tristanrobert

Describe the current behavior

When you download via API an attachment file, for instance with a n8n Http request node the URI is malformed. n8n follows RFC 5987 and decodeURIComponent.

Steps to reproduce

1.When you download via API, for instance with a n8n Http request node the URI is malformed. n8n follows RFC 5987 and decodeURIComponent(filename).
2.
3.

Describe the expected behavior

It would be better to add a filename* with encoded filename to sanitize it. https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Disposition

Where have you encountered this bug?

Instance information (when self-hosting only)

  • Grist instance:

    • Version: 1.7.3
    • URL (if it's OK for you to share it):
    • Installation mode: docker
    • Architecture: single-worker
  • Browser name, version and platforms on which you could reproduce the bug: n8n 1.110.1

  • Link to browser console log if relevant:

  • Link to server log if relevant:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions