Restore recently-broken notifier: getNotifier() should succeed even if notifier is empty. (#1841)

dsagal · web-flow · commit 6553c8e68c33 · 2025-09-15T14:29:01.000-04:00
Prior to 43faaba, getNotifier() wasn't using the hasNotifier() check, but succeeded whenever a notifier was "configured" (by adding addNotifier()), even if it was configured with the "empty notifier". This restores previous behavior. Any home server calls addNotifier(), and the updated check restores the behavior of only checking if addNotifier() has been called. ## Has this been tested? Tests have been failing since 43faaba, and should now pass.
diff --git a/app/server/lib/FlexServer.ts b/app/server/lib/FlexServer.ts
@@ -455,8 +455,9 @@ export class FlexServer implements GristServer {
   }
 
   public getNotifier(): INotifier {
-    // Check that our internal notifier implementation is in place.
-    if (!this.hasNotifier()) { throw new Error('no notifier available'); }
+    // We only warn if we are in a server that doesn't configure notifiers (i.e. not a home
+    // server). But actually having a working notifier isn't required.
+    if (!this._has('notifier')) { throw new Error('no notifier available'); }
     // Expose a wrapper around it that emits actions.
     return this._emitNotifier;
   }

Original file line number	Diff line number	Diff line change
`@@ -455,8 +455,9 @@ export class FlexServer implements GristServer {`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`public getNotifier(): INotifier {`
`458`		`- // Check that our internal notifier implementation is in place.`
`459`		`- if (!this.hasNotifier()) { throw new Error('no notifier available'); }`
	`458`	`+ // We only warn if we are in a server that doesn't configure notifiers (i.e. not a home`
	`459`	`+ // server). But actually having a working notifier isn't required.`
	`460`	`+ if (!this._has('notifier')) { throw new Error('no notifier available'); }`
`460`	`461`	`// Expose a wrapper around it that emits actions.`
`461`	`462`	`return this._emitNotifier;`
`462`	`463`	`}`