Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Migrating to k6-core's linter #1292

@inancgumus

Description

@inancgumus

What?

  • k6-core and k6-browser linter configurations do not match.
  • Use k6-core's version directly or use it as the base and extend it with k6-browser's additional rules.

Why?

  • To rely on a shared and reviewed configuration across teams.
  • To prevent security issues like setInputFiles.

How?

k6-core prefers to use the same rules used in the linter configuration to sync across the projects (or extensions in general). k6-core has created a reusable workflow that they've been using for other minor extensions, as well. A concrete example is related to the os package which is denied in the k6-core configuration.

They suggest k6-browser to use the entire workflow here for example. Or, only the linter configuration part. They believe a better case would be the ability to merge two golangci configurations, but they don't find it as a solution at the moment.

Tasks

### Tasks
- [ ] Work with the same linter + dependency job -- see [comment](https://github.com/grafana/xk6-browser/issues/1292#issuecomment-2092665993)
- [ ] Work with the same test jobs -- see [comment](https://github.com/grafana/xk6-browser/issues/1292#issuecomment-2092708331)
- [ ] Fix older lint issues
- [ ] Migrate fully to work with https://github.com/grafana/k6-ci

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions