Refactor if to make it easier to read

ankur22 · ankur22 · commit c38371d10c26 · 2024-11-18T13:42:36.000Z
(A || B) == (!A &amp;&amp; !B)
diff --git a/common/frame_manager.go b/common/frame_manager.go
@@ -245,7 +245,7 @@ func (m *FrameManager) frameNavigated(frameID cdp.FrameID, parentFrameID cdp.Fra
 	isMainFrame := parentFrameID == ""
 	frame := m.frames[frameID]
 
-	if !(isMainFrame || frame != nil) {
+	if !isMainFrame && frame == nil {
 		return errors.New("we either navigate top level or have old version of the navigated frame")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ func (m *FrameManager) frameNavigated(frameID cdp.FrameID, parentFrameID cdp.Fra`
`245`	`245`	`isMainFrame := parentFrameID == ""`
`246`	`246`	`frame := m.frames[frameID]`
`247`	`247`
`248`		`- if !(isMainFrame \|\| frame != nil) {`
	`248`	`+ if !isMainFrame && frame == nil {`
`249`	`249`	`return errors.New("we either navigate top level or have old version of the navigated frame")`
`250`	`250`	`}`
`251`	`251`