Skip to content

Alllex/qa/deincubate public buildlayout #35264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Alllex/qa/deincubate public buildlayout #35264

wants to merge 5 commits into from

Conversation

alllex
Copy link
Member

@alllex alllex commented Oct 10, 2025

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

alllex added 5 commits August 2, 2025 00:26
@alllex
Introduce BuildLocations as replacement for BuildLayout
ea7e5f9 
The internal BuildLayout service is not in an explicit
internal package despite not being part of the public API.
It is often mistakenly injected by users, and we even had
an userguide snippet using it. The confusing partly comes
from the fact that we have a public BuildLayout service,
which lives in another package.

Introducing a new internal service makes the distinction clear.
@alllex
Deprecate internal BuildLayout and SettingsLocation
3893923
@alllex
Remove internal service usage from a snippet
5403654
@alllex
Clarify javadoc for getSettingsFile regarding effective settings fi…
c27c509 
…le behavior
@alllex
Polish DefaultSettingsLoader
a75f611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alllex