Skip to content

Use problem information in build failure message #31374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 22, 2024
Merged

Use problem information in build failure message #31374

merged 5 commits into from
Nov 22, 2024

Conversation

donat
Copy link
Member

@donat donat commented Nov 21, 2024 •
edited
Loading

Fixes #31376

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@donat

This comment has been minimized.

Sign in to view
@donat donat changed the title Donat/problems/render problems on cli Use problem information in build failure message Nov 21, 2024
@bot-gradle

This comment has been minimized.

Sign in to view
@donat donat force-pushed the donat/problems/render-problems-on-cli branch from 0cdd3e3 to 9613256 Compare November 21, 2024 13:09
donat
donat commented Nov 21, 2024
View reviewed changes
...ide/problems-api/src/main/java/org/gradle/api/problems/internal/InternalProblemReporter.java
* @return nothing, the method throws an exception
* @since 8.12
*/
RuntimeException throwing(Throwable exception, Collection<? extends Problem> problems);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to do the API cleanup separately.

@bot-gradle

This comment has been minimized.

Sign in to view
@donat donat force-pushed the donat/problems/render-problems-on-cli branch from 9613256 to 568dfab Compare November 21, 2024 13:30
@donat donat requested a review from hegyibalint November 21, 2024 13:30
@donat donat force-pushed the donat/problems/render-problems-on-cli branch from 568dfab to d15be93 Compare November 21, 2024 13:30
@donat

This comment has been minimized.

Sign in to view
@donat donat marked this pull request as ready for review November 21, 2024 13:31
@bot-gradle

This comment has been minimized.

Sign in to view
@donat donat requested review from a team as code owners November 21, 2024 13:31
@donat donat requested review from a team and tresat November 21, 2024 13:31
@bot-gradle

This comment has been minimized.

Sign in to view
hegyibalint
hegyibalint requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@hegyibalint hegyibalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see this shaping up!
Left some comments, PTAL.

platforms/ide/problems-api/src/main/java/org/gradle/api/problems/internal/ProblemLookup.java
* @since 8.10
*/
Collection<Problem> getProblems();
public interface ProblemLookup {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Something doesn't click with me with this classname, but I cannot come up with something better either.
Any case, this is internal so if we come up with something better, we can change it anytime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProblemLocator?

...rojects/build-events/src/main/java/org/gradle/internal/build/event/types/DefaultFailure.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice cleanup, happy to see that exception mapping go away (at least from here)

@donat
Copy link
Member Author

donat commented Nov 21, 2024

@hegyibalint Thanks for the review, I'll clean up the items. Some of the issues come from cherry-picking changes from another (wip) branch.

@donat donat requested a review from hegyibalint November 21, 2024 14:37
@donat

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
hegyibalint
hegyibalint approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@hegyibalint hegyibalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, let's merge this!

@bot-gradle
Copy link
Collaborator

The following builds have failed:

@donat
Copy link
Member Author

donat commented Nov 22, 2024

@bot-gradle merge

@bot-gradle bot-gradle added this pull request to the merge queue Nov 22, 2024