Skip to content

Conversation

lacasseio
Copy link
Contributor

Fixes #29492

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • [N/A] Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@lacasseio lacasseio requested review from a team June 15, 2024 11:07
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Jun 15, 2024
@big-guy big-guy self-assigned this Jun 17, 2024
@big-guy big-guy self-requested a review June 17, 2024 15:19
@big-guy big-guy added the 👋 team-triage Issues that need to be triaged by a specific team label Jun 17, 2024
@big-guy big-guy added this to the 8.10 RC1 milestone Jun 17, 2024
@ljacomet ljacomet added in:native-platform c, cpp, swift and other native languages support, etc and removed