-
Notifications
You must be signed in to change notification settings - Fork 5k
Description
Current Behavior
Gradle wrapper adds networkTimeout=10000
into gradle-wrapper.properties
even though it is an incubating feature introduced by #17575. But this property is already optional. If not present, it would default to the previously hard-coded setting.
Expected Behavior
Incubating features should not be forced on us. We should be able to opt in to using it. Otherwise if the feature implementation changes, all projects upgrading to Gradle 7.6+ will have to update their projects to fix the incompatibility. For example, you might rename this option to networkTimeoutInMs
to indicate that the value is in milliseconds. (Which is not a bad thing at all, not knowing the unit is a common issue in software engineering due to how we name our variables/properties.)
Context (optional)
No response
Steps to Reproduce
- First make sure
gradle-wrapper.properties
does not have anetworkTimeout
property (remove it if it was already there). - Then run the
wrapper
task.
Gradle version
7.6.3
Build scan URL (optional)
No response
Your Environment (optional)
No response