Apply review changes

jvandort · jvandort · commit 03406e313823 · 2025-01-15T12:01:31.000-05:00
diff --git a/platforms/core-runtime/base-services/src/main/java/org/gradle/internal/graph/CachingDirectedGraphWalker.java b/platforms/core-runtime/base-services/src/main/java/org/gradle/internal/graph/CachingDirectedGraphWalker.java
@@ -40,6 +40,11 @@ public class CachingDirectedGraphWalker<N, T> {
     private final DirectedGraphWithEdgeValues<N, T> graph;
     private List<N> startNodes = new ArrayList<N>();
     private Set<NodeDetails<N, T>> strongComponents = new LinkedHashSet<NodeDetails<N, T>>();
+
+    /**
+     * We use an immutable set for cached node values since the cache can become quite large
+     * for very large graphs, and immutable sets are much more memory efficient than LinkedHashSets.
+     */
     private final Map<N, ImmutableSet<T>> cachedNodeValues = new HashMap<N, ImmutableSet<T>>();
 
     public CachingDirectedGraphWalker(DirectedGraph<N, T> graph) {
@@ -162,8 +167,6 @@ private Set<T> doSearch() {
                 } else {
                     // Not part of a strongly connected component or the root of a strongly connected component
                     for (NodeDetails<N, T> componentMember : details.componentMembers) {
-                        // We use an immutable set for cached node values since the cache can become quite large
-                        // for very large graphs, and immutable sets are much more memory efficient than LinkedHashSets.
                         cachedNodeValues.put(componentMember.node, ImmutableSet.copyOf(details.values));
                         componentMember.finished = true;
                         components.remove(componentMember.component);
diff --git a/platforms/native/platform-native/src/main/java/org/gradle/nativeplatform/toolchain/internal/msvcpp/ArchitectureDescriptorBuilder.java b/platforms/native/platform-native/src/main/java/org/gradle/nativeplatform/toolchain/internal/msvcpp/ArchitectureDescriptorBuilder.java
@@ -182,7 +182,7 @@ Map<String, String> getDefinitions() {
     ArchitectureSpecificVisualCpp buildDescriptor(VersionNumber compilerVersion, File basePath, File vsPath) {
         File commonTools = new File(vsPath, PATH_COMMONTOOLS);
         File commonIde = new File(vsPath, PATH_COMMONIDE);
-        List<File> paths = new ArrayList<>();
+        List<File> paths = new ArrayList<>(3);
         paths.add(commonTools);
         paths.add(commonIde);
         File crossCompilePath = getCrossCompilePath(basePath);
