Skip to content

fix: Update stream_ack_deadline with ack_deadline #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2022
Merged

fix: Update stream_ack_deadline with ack_deadline #763

merged 4 commits into from
Aug 11, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Aug 11, 2022 •
edited
Loading

Updates stream_ack_deadline along with ack_deadline to prevent a lower stream_ack_deadline being sent on the heartbeat if the ack_deadline has been updated.
Correctly sets initial request ack_deadline_seconds to stream_ack_deadline instead of ack_deadline
Fixes #758 🦕

@acocuzzo acocuzzo requested review from a team as code owners August 11, 2022 18:17
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Aug 11, 2022
@acocuzzo acocuzzo added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small. labels Aug 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 11, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@acocuzzo acocuzzo merged commit e600ad8 into googleapis:main Aug 11, 2022
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maheshgattani maheshgattani maheshgattani approved these changes

Assignees

@maheshgattani maheshgattani

@kamalaboulhosn kamalaboulhosn

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default stream_ack_deadline to 60 sec, or via max_duration_per_lease_extension
3 participants
@acocuzzo @maheshgattani @kamalaboulhosn