Skip to content

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Jul 14, 2022

Removes bidi modacks on from streamingpull initial request.
Causes issue when the size of the request exceeds server-side-flow-control and result in 400 invalid argument error, which can occur with >100,000 messages are being leased.
Furthermore, all modacks should be done out-of-band and not on the bidi stream.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #706 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Jul 14, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@acocuzzo acocuzzo marked this pull request as ready for review July 15, 2022 15:30
@acocuzzo acocuzzo requested review from a team as code owners July 15, 2022 15:30
@acocuzzo acocuzzo merged commit 1e7d469 into googleapis:main Jul 15, 2022
@acocuzzo acocuzzo changed the title fix: Remove bidi modacks on streamingpull initial request fix: Remove Bidi ModAcks on StreamingPull initial request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google.api_core.exceptions.InvalidArgument: 400 Request contains an invalid argument.
4 participants