Skip to content

fix: DataFrameGroupby.agg now works with unnamed tuples #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix: DataFrameGroupby.agg now works with unnamed tuples #985

merged 3 commits into from
Sep 13, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners September 13, 2024 16:42
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 13, 2024
@TrevorBergeron TrevorBergeron changed the title fix: DataFrameGroupby.agg no works with unnamed tuples fix: DataFrameGroupby.agg now works with unnamed tuples Sep 13, 2024
sycai
sycai requested changes Sep 13, 2024
View reviewed changes
tests/system/small/test_groupby.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also add test cases for:

  • v is not a tuple
  • v is a tuple but its length is not 2
    ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@TrevorBergeron TrevorBergeron enabled auto-merge (squash) September 13, 2024 19:21
@TrevorBergeron TrevorBergeron merged commit 0f047b4 into main Sep 13, 2024
20 of 23 checks passed
@TrevorBergeron TrevorBergeron deleted the more_groupby branch September 13, 2024 20:03
@release-please release-please bot mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sycai sycai sycai approved these changes

Assignees

@rey-esp rey-esp

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron @sycai @rey-esp