Skip to content

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Jun 18, 2024

This addresses the comment #629 (comment)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) https://screenshot.googleplex.com/3YqRc58mWfPW5an

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners June 18, 2024 23:58
@shobsi shobsi requested a review from milkshakeiii June 18, 2024 23:58
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 18, 2024
@shobsi shobsi requested a review from tswast June 19, 2024 00:26
@tswast tswast merged commit 487dff6 into main Jun 26, 2024
@tswast tswast deleted the shobs-axis-1-docs branch June 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants