Skip to content

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Apr 8, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 333397327 🦕

@shobsi shobsi requested review from a team as code owners April 8, 2024 17:30
@shobsi shobsi requested a review from junyazhang April 8, 2024 17:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Apr 8, 2024
@shobsi shobsi marked this pull request as draft April 8, 2024 17:39
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 9, 2024
@shobsi shobsi marked this pull request as ready for review April 9, 2024 06:39
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit a557ea2 into main Apr 10, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-docs-str branch April 10, 2024 02:00
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants