feat: Allow join-free alignment of analytic expressions #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
reviewed
Nov 22, 2024
bigframes/core/nodes.py
Outdated
| def replace_child( | ||
| self, new_child: BigFrameNode, validate: bool = False | ||
| ) -> UnaryNode: | ||
| new_self = replace(self, child=new_child) # type: ignore |
There was a problem hiding this comment.
I had to open up the file to figure out this is from dataclasses. Per https://google.github.io/styleguide/pyguide.html#s2.2-imports please import dataclasses, not individual functions / classes from it. dataclasses is not one of the allowed exceptions.
There was a problem hiding this comment.
fixed this import
bigframes/core/nodes.py
Outdated
| self, new_child: BigFrameNode, validate: bool = False | ||
| ) -> UnaryNode: | ||
| new_self = replace(self, child=new_child) # type: ignore | ||
| if validate: |
Collaborator
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕