Skip to content

docs: show best practice of closing the session to cleanup resources in sample notebooks #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 18, 2024
Merged

docs: show best practice of closing the session to cleanup resources in sample notebooks #1095

merged 9 commits into from
Oct 18, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Oct 17, 2024 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
docs: show best practice of closing the session to cleanup resources in sample notebooks (#1095)

test: include stale cloud functions cleanup in the default nox run (#1095)
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners October 17, 2024 23:05
@shobsi shobsi requested a review from tswast October 17, 2024 23:05
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 17, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 17, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Oct 18, 2024
@shobsi shobsi changed the title chore: clean up stale cloud functions up in default nox run chore: cleanup in default nox runs, make remote function notebooks self cleaning Oct 18, 2024
@shobsi shobsi changed the title chore: cleanup in default nox runs, make remote function notebooks self cleaning chore: cleanup in default nox runs, self cleaning in remote function notebooks Oct 18, 2024
tswast
tswast approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks so much for helping document these best practices, Shobhit.

@tswast tswast changed the title chore: cleanup in default nox runs, self cleaning in remote function notebooks docs: show best practice of closing the session to cleanup resources in sample notebooks Oct 18, 2024
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 62a88e8 into main Oct 18, 2024
18 of 23 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-cleanup-default branch October 18, 2024 20:22
@release-please release-please bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

@jiaxunwu jiaxunwu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shobsi @tswast @jiaxunwu