Skip to content

feat: implement parallel operations #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 5, 2022
Merged

feat: implement parallel operations #2067

merged 25 commits into from
Dec 5, 2022

Conversation

ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Sep 15, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1868 🦕
Fixes #2051

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 15, 2022
@ddelgrosso1
Copy link
Contributor Author

Opening as a draft PR while I add in JSDoc comments so that I can start gathering feedback / initial thoughts.

@ddelgrosso1 ddelgrosso1 changed the base branch from main to transfer-manager September 16, 2022 14:46
@ddelgrosso1
Copy link
Contributor Author

ddelgrosso1 commented Sep 16, 2022 •
edited
Loading

Repointing this at a new branch named transfer-manager. My plan is to release this as a "preview" from that branch. Since this is a new feature, keeping it in sync with main should be relatively headache free until such a point that we deem the feature stable.

danielduhh
danielduhh reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@danielduhh danielduhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple passthrough comments/questions :)

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Sep 30, 2022
@ddelgrosso1 ddelgrosso1 changed the base branch from transfer-manager to main September 30, 2022 17:50
@ddelgrosso1 ddelgrosso1 changed the base branch from main to transfer-manager September 30, 2022 17:51
shaffeeullah
shaffeeullah reviewed Oct 13, 2022
View reviewed changes
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Oct 24, 2022
@ddelgrosso1 ddelgrosso1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 24, 2022
@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review October 24, 2022 15:26
@ddelgrosso1 ddelgrosso1 requested review from a team as code owners October 24, 2022 15:27
@ddelgrosso1 ddelgrosso1 changed the base branch from transfer-manager to main October 24, 2022 15:27
@ddelgrosso1 ddelgrosso1 changed the base branch from main to transfer-manager October 24, 2022 15:27
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 29, 2022
@ddelgrosso1 ddelgrosso1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2022