Skip to content

fix: fix Journaling BlobWriteSessionConfig to properly handle multiple consecutive retries #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix: fix Journaling BlobWriteSessionConfig to properly handle multiple consecutive retries #3166

merged 1 commit into from
Jun 25, 2025

Conversation

BenWhitehead
Copy link
Collaborator

  • Clear copy buffer used to load bytes from the recovery file so, we don't have dangling bytes from a previous retry
  • Do not add to the cumulative crc32c when retrying. The bytes have already been added in the first attempt.

@BenWhitehead
fix: fix Journaling BlobWriteSessionConfig to properly handle multipl…
1f14915 
…e consecutive retries

* Clear copy buffer used to load bytes from the recovery file so, we don't have dangling bytes from a previous retry
* Do not add to the cumulative crc32c when retrying. The bytes have already been added in the first attempt.
@BenWhitehead BenWhitehead requested a review from a team as a code owner June 24, 2025 19:31
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Jun 24, 2025
cojenco
cojenco approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for walking me through the changes!

@BenWhitehead BenWhitehead merged commit 895bfbd into main Jun 25, 2025
25 checks passed
@BenWhitehead BenWhitehead deleted the fix/grpc/journaling/multiple-retry branch June 25, 2025 22:14
@release-please release-please bot mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWhitehead @cojenco