fix(deps): Update the Java code generator (gapic-generator-java) to 2.31.0 #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @suztomo, PR is missing grpc artifact IIUC comparing it against storage-v2; |
sydney-munro
approved these changes
Jan 8, 2024
I thought we didn't need it so I didn't add grpc- part in https://github.com/googleapis/java-storage/pull/2347/files. Do you need it? |
|
"ci / dependencies (17)" failed https://github.com/googleapis/java-storage/actions/runs/7429540884/job/20218238157?pr=2349. This is just a matter of removing the unused dependency from the pom.xml. |
suztomo
requested changes
Jan 8, 2024
| @@ -197,6 +202,7 @@ | |||
| <module>google-cloud-storage</module> | |||
| <module>grpc-google-cloud-storage-v2</module> | |||
| <module>proto-google-cloud-storage-v2</module> | |||
| <module>proto-google-cloud-storage-control-v2</module> | |||
There was a problem hiding this comment.
@sydney-munro google-cloud-storage-control module is missing. Would you add it?
suztomo
requested changes
Jan 8, 2024
There was a problem hiding this comment.
@sydney-munro google-cloud-storage-control is missing pom.xml. Can you create one by copying contents from https://github.com/googleapis/java-storage/blob/main/gapic-google-cloud-storage-v2/pom.xml (You need to edit artifact IDs and might need to adjust dependencies) If that's a trouble for you, I can help.
suztomo
approved these changes
Jan 9, 2024
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>com.google.cloud</groupId> |
sydney-munro
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 596645164
Source-Link: googleapis/googleapis@4a0e62e
Source-Link: https://github.com/googleapis/googleapis-gen/commit/a10ed6a77676c37e60799098d48d0afb16008613
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTEwZWQ2YTc3Njc2YzM3ZTYwNzk5MDk4ZDQ4ZDBhZmIxNjAwODYxMyJ9
feat: add Storage Control API
PiperOrigin-RevId: 596130676
Source-Link: googleapis/googleapis@ce07d24
Source-Link: https://github.com/googleapis/googleapis-gen/commit/7de5bf064581832c3fff93ab51b4c0b1d0d14aa1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2RlNWJmMDY0NTgxODMyYzNmZmY5M2FiNTFiNGMwYjFkMGQxNGFhMSJ9