Skip to content

fix: update GrpcStorageImpl.createFrom(BlobInfo, Path) to use RewindableContent #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix: update GrpcStorageImpl.createFrom(BlobInfo, Path) to use RewindableContent #2112

merged 1 commit into from
Jul 14, 2023

Conversation

BenWhitehead
Copy link
Collaborator

With the introduction of RewindableContent, we can now upload an entire file in a single WriteObjectRequest stream.

  • chore: rename RewindableHttpContent -> RewindableContent

@BenWhitehead BenWhitehead added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:ignore instruct owl-bot to ignore a PR labels Jul 13, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner July 13, 2023 01:54
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Jul 13, 2023
@BenWhitehead BenWhitehead force-pushed the blob-write-channel-v2 branch from a1a01f8 to 5cc8745 Compare July 13, 2023 20:51
@BenWhitehead BenWhitehead requested a review from a team as a code owner July 13, 2023 20:51
@BenWhitehead BenWhitehead force-pushed the grpc-createFrom-smarter branch from 3db650a to 1cb8340 Compare July 13, 2023 20:56
Base automatically changed from blob-write-channel-v2 to main July 13, 2023 23:20
@BenWhitehead BenWhitehead force-pushed the grpc-createFrom-smarter branch 3 times, most recently from a2b8fda to 770b5bf Compare July 14, 2023 16:26
@BenWhitehead BenWhitehead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 14, 2023
@BenWhitehead
fix: update GrpcStorageImpl.createFrom(BlobInfo, Path) to use Rewinda…
af24360 
…bleContent

With the introduction of RewindableContent, we can now upload an entire file in a single WriteObjectRequest stream.

* chore: rename RewindableHttpContent -> RewindableContent
@BenWhitehead BenWhitehead force-pushed the grpc-createFrom-smarter branch from 770b5bf to af24360 Compare July 14, 2023 19:48
@BenWhitehead BenWhitehead merged commit c805051 into main Jul 14, 2023
@BenWhitehead BenWhitehead deleted the grpc-createFrom-smarter branch July 14, 2023 20:08
@release-please release-please bot mentioned this pull request Jul 14, 2023
Merged
@lucymcnatt lucymcnatt mentioned this pull request Sep 29, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.
Projects
None yet
Milestone
Storage gRPC implementation
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWhitehead @frankyn