Skip to content

feat: add Autoclass support and sample #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 7, 2022
Merged

feat: add Autoclass support and sample #1697

merged 6 commits into from
Nov 7, 2022

Conversation

JesseLovelace
Copy link
Contributor

#1598

Adds support and samples for Autoclass

@JesseLovelace JesseLovelace requested a review from a team as a code owner October 6, 2022 22:01
@snippet-bot
Copy link

snippet-bot bot commented Oct 6, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Oct 6, 2022
@JesseLovelace JesseLovelace changed the title Add Autoclass support and sample feat:Add Autoclass support and sample Oct 6, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@JesseLovelace JesseLovelace changed the title feat:Add Autoclass support and sample feat: add Autoclass support and sample Oct 6, 2022
@JesseLovelace JesseLovelace requested a review from cojenco October 6, 2022 22:04
BenWhitehead
BenWhitehead requested changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things to address. Thanks for adding this!

@BenWhitehead
Copy link
Collaborator

I almost forgot, can you also add the new Storage.BucketField.AUTOCLASS enum to allow specifically selecting it (and update the field tests in ITOptionRegressionTest accordingly)?

@JesseLovelace
Copy link
Contributor Author

It appears to already be there?
https://github.com/googleapis/java-storage/blob/feat/grpc-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java#L151

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITOptionRegressionTest.java

Line 326 in e6b12a7

"autoclass",

@JesseLovelace JesseLovelace requested a review from a team as a code owner October 7, 2022 17:54
@BenWhitehead
Copy link
Collaborator

Ah, you're right. Thanks for double checking.

@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 20, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2022
@BenWhitehead BenWhitehead changed the base branch from feat/grpc-storage to main October 26, 2022 20:13
@cojenco
Copy link
Contributor

cojenco commented Oct 27, 2022

Update: per offline discussion, GA is tentatively postponed to Nov 7 as the backend team is monitoring feature and UI rollout. I will comment once the timeline is confirmed.

Additionally, samples tests are pending feature complete rollout or for the newly added samples project to be allowlisted

@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2022
@cojenco cojenco added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 1, 2022
cojenco
cojenco approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge and release, thank you!

@JesseLovelace JesseLovelace merged commit 82aacd7 into main Nov 7, 2022
@JesseLovelace JesseLovelace deleted the featautoclass branch November 7, 2022 17:19
@release-please release-please bot mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@cojenco cojenco cojenco approved these changes

Assignees

@lesv lesv

Labels
api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JesseLovelace @BenWhitehead @cojenco @lesv @yoshi-kokoro