Skip to content

feat: Add samples for backup schedule feature APIs. #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2024
Merged

feat: Add samples for backup schedule feature APIs. #3339

merged 6 commits into from
Sep 25, 2024

Conversation

aman-19
Copy link
Contributor

@aman-19 aman-19 commented Sep 18, 2024

This PR adds code samples for the following APIs:

  1. CreateBackupSchedule (both full and incremental backup schedules)
  2. ListBackupSchedules
  3. GetBackupSchedule
  4. UpdateBackupSchedule
  5. DeleteBackupSchedule

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3338 ☕️

@aman-19 aman-19 requested a review from a team as a code owner September 18, 2024 12:54
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Sep 18, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Sep 18, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
ketanv3
ketanv3 reviewed Sep 20, 2024
View reviewed changes
ketanv3
ketanv3 approved these changes Sep 23, 2024
View reviewed changes
Copy link

@ketanv3 ketanv3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few minor changes needed.

@ketanv3
Copy link

ketanv3 commented Sep 23, 2024

Thanks for the changes, @aman-19. LGTM!

@rahul2393 rahul2393 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed api: spanner Issues related to the googleapis/java-spanner API. labels Sep 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Sep 24, 2024
@rahul2393 rahul2393 merged commit 8cd5163 into googleapis:main Sep 25, 2024
30 of 31 checks passed
@release-please release-please bot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

+1 more reviewer

@ketanv3 ketanv3 ketanv3 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@minherz minherz

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add samples for Cloud Spanner Schedules Backups
5 participants
@aman-19 @ketanv3 @rahul2393 @minherz @yoshi-kokoro