Skip to content

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Oct 12, 2022

When AggregateQuery was added by #1033 it failed to implement any "retry" logic. This PR adds in that retry logic, based heavily on the pre-existing retry logic from the Query class.

@dconeybe dconeybe added the api: firestore Issues related to the googleapis/java-firestore API. label Oct 12, 2022
@dconeybe dconeybe self-assigned this Oct 12, 2022
@dconeybe dconeybe added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@dconeybe dconeybe requested a review from wu-hui October 12, 2022 03:19
@dconeybe dconeybe marked this pull request as ready for review October 13, 2022 01:00
@dconeybe dconeybe requested a review from a team as a code owner October 13, 2022 01:00
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM!

@wu-hui wu-hui removed their assignment Oct 18, 2022
@dconeybe dconeybe merged commit 5789e4b into main Oct 18, 2022
@dconeybe dconeybe deleted the dconeybe/CountQueryRetry branch October 18, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants