feat(samples): add all feature values samples #981

sai-chaithu · 2022-06-28T09:18:56Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #945 ☕️

generated-files-bot · 2022-06-28T09:19:01Z

Warning: This pull request is touching the following templated files:

samples/install-without-bom/pom.xml
samples/snapshot/pom.xml
samples/snippets/pom.xml

snippet-bot · 2022-06-28T09:19:01Z

Here is the summary of changes.

You are about to add 5 region tags.

samples/snippets/src/main/java/aiplatform/BatchCreateFeaturesSample.java:24, tag aiplatform_batch_create_features_sample
samples/snippets/src/main/java/aiplatform/BatchReadFeatureValuesSample.java:25, tag aiplatform_batch_read_feature_values_sample
samples/snippets/src/main/java/aiplatform/ExportFeatureValuesSample.java:24, tag aiplatform_export_feature_values_sample
samples/snippets/src/main/java/aiplatform/ExportFeatureValuesSnapshotSample.java:24, tag aiplatform_export_feature_values_snapshot_sample
samples/snippets/src/main/java/aiplatform/ImportFeatureValuesSample.java:24, tag aiplatform_import_feature_values_sample

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

gkc2104 · 2022-07-08T02:34:40Z

samples/snippets/src/main/java/aiplatform/BatchCreateFeaturesSample.java

+          .setParent(EntityTypeName.of(project, location, featurestoreId, entityTypeId).toString())
+          .addAllRequests(createFeatureRequests).build();
+
+      OperationFuture<BatchCreateFeaturesResponse, BatchCreateFeaturesOperationMetadata> future =


Name the operationFutures consistently across the files, maybe use batchCreateFeaturesOperationFuture or just future, but use same across.

ok, will use same across

gkc2104 · 2022-07-08T02:36:54Z

samples/snippets/src/main/java/aiplatform/BatchCreateFeaturesSample.java

+      List<CreateFeatureRequest> createFeatureRequests = new ArrayList<>();
+
+      Feature titleFeature = Feature.newBuilder().setDescription("The title of the movie")
+          .setValueType(ValueType.valueOf("STRING")).build();


Use the ENUM directly here and in other places as well.

Sure, will update to ENUM type everywhere as below,

Suggested change

.setValueType(ValueType.valueOf("STRING")).build();

.setValueType(ValueType.STRING).build();

gkc2104 · 2022-07-08T02:39:31Z

samples/snippets/src/main/java/aiplatform/BatchCreateFeaturesSample.java

+
+      Feature titleFeature = Feature.newBuilder().setDescription("The title of the movie")
+          .setValueType(ValueType.valueOf("STRING")).build();
+      Feature genresFeature = Feature.newBuilder().setDescription("The genres of the movie")


nit: change to singular genre, to me genres represents an array of genres.

Using the same features as https://github.com/GoogleCloudPlatform/vertex-ai-samples/blob/main/notebooks/official/feature_store/gapic-feature-store.ipynb sample tutorial provided in SOW.
So thought it is ok, should we change it here?

Oh I see, let's retain it for now. It was a minor nit.

gkc2104 · 2022-07-08T02:40:34Z

samples/snippets/src/main/java/aiplatform/BatchCreateFeaturesSample.java

+      System.out.format("Operation name: %s%n", future.getInitialFuture().get().getName());
+      System.out.println("Waiting for operation to finish...");
+      BatchCreateFeaturesResponse batchCreateFeaturesResponse =
+          future.get(timeout, TimeUnit.SECONDS);


just to confirm, is the behavior here to wait the 300 sec and timeout otherwise. If there is a response available, it's returned.

yes, if the response is not received in 300 sec it will throw timeout

gkc2104 · 2022-07-08T02:41:54Z

samples/snippets/src/main/java/aiplatform/BatchReadFeatureValuesSample.java

+              .setCsvReadInstances(CsvSource.newBuilder().setGcsSource(gcsSource))
+              .setDestination(
+                  FeatureValueDestination.newBuilder().setBigqueryDestination(bigQueryDestination))
+              // .addAllPassThroughFields(passThroughFieldsList)


should we include this as well, if possible ?

removing that as there are no passThroughFields for the movie prediction example.

gkc2104 · 2022-07-08T02:42:59Z

samples/snippets/src/main/java/aiplatform/ExportFeatureValuesSample.java

+      List<String> ids = new ArrayList<>();
+      ids.add("*");
+      FeatureSelector featureSelector = FeatureSelector.newBuilder()
+          .setIdMatcher(IdMatcher.newBuilder().addAllIds(ids).build()).build();


nit: inline something like addAllIds(ArrayList.of()...), or make a class variable if intended for developer to update.

ok, will add inline as below,

Suggested change

.setIdMatcher(IdMatcher.newBuilder().addAllIds(ids).build()).build();

.setIdMatcher(IdMatcher.newBuilder().addAllIds(Arrays.asList("title","genres","average_rating")).build()).build();

I feel it's better to make it one of the variables the developer has to update and pass it down here.

updated code to pass the feature selector ids as a list object

…and list variable

dizcology

Please make sure sample tests pass before merging.

sai-chaithu added 2 commits June 28, 2022 14:15

feat(samples): add all feature values samples

bf572d9

feat(samples): update all feature values samples

bc3e57c

sai-chaithu requested review from a team as code owners June 28, 2022 09:18

product-auto-label bot added size: l Pull request size is large. api: vertex-ai Issues related to the googleapis/java-aiplatform API. samples Issues that are directly related to samples. labels Jun 28, 2022

blunderbuss-gcf bot assigned shubha-rajan Jun 28, 2022

diemtvu added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022

feat(samples): update big query dependency in pom.xml

1a6146c

junkourata self-requested a review July 8, 2022 01:09

junkourata approved these changes Jul 8, 2022

View reviewed changes

junkourata requested a review from dizcology July 8, 2022 01:12

junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022

gkc2104 reviewed Jul 8, 2022

View reviewed changes

sai-chaithu and others added 4 commits July 8, 2022 11:24

Merge branch 'googleapis:main' into FeatureValuesSamples

d34e7e6

feat(samples): code review changes

71bdbce

Merge branch 'googleapis:main' into FeatureValuesSamples

7f578ac

feat(samples): updated feature values samples with close method call …

4fdda94

…and list variable

junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2022

junkourata added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2022

dizcology approved these changes Aug 2, 2022

View reviewed changes

	.setValueType(ValueType.valueOf("STRING")).build();
	.setValueType(ValueType.STRING).build();

	.setIdMatcher(IdMatcher.newBuilder().addAllIds(ids).build()).build();
	.setIdMatcher(IdMatcher.newBuilder().addAllIds(Arrays.asList("title","genres","average_rating")).build()).build();

feat(samples): add all feature values samples #981

feat(samples): add all feature values samples #981

Uh oh!

Conversation

sai-chaithu commented Jun 28, 2022

Uh oh!

generated-files-bot bot commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snippet-bot bot commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sai-chaithu Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dizcology left a comment

Choose a reason for hiding this comment

Uh oh!

generated-files-bot bot commented Jun 28, 2022 •

edited

Loading

snippet-bot bot commented Jun 28, 2022 •

edited

Loading

sai-chaithu Jul 8, 2022 •

edited

Loading