fix(bazel): Remove monolith imports from Python µgen Bazel rules #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 27
Lines ? 1703
Branches ? 347
==========================================
Hits ? 1703
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
software-dov
approved these changes
Jun 18, 2021
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed so that we can remove the monolith from googleapis's
switched_rules_by_language. Without this change,py_gapictargets that depend on aproto_library_with_infotarget will fail to build, because the monolith import clobbers the@rules_gapic//:proto_library_with_infoimport in googleapis.We need to temporarily disable the integration tests because the googleapis depndencies (e.g.
asset_proto) were themselves dependent on the monolith's rules... but that import must be removed here in order to facilitate removing the monolith from googleapis. These tests will be re-enabled once the googleapis change is done.