Skip to content

fix: fix syntax errors and failing unit tests #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2021
Merged

fix: fix syntax errors and failing unit tests #849

merged 2 commits into from
Apr 28, 2021

Conversation

busunkim96
Copy link
Contributor

Fixes #848

@busunkim96 busunkim96 requested a review from a team as a code owner April 27, 2021 23:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #849 (6511107) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #849   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1653   +45     
  Branches       328       337    +9     
=========================================
+ Hits          1608      1653   +45
Impacted Files Coverage Δ
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/metadata.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
gapic/utils/checks.py 100.00% <100.00%> (ø)
gapic/utils/options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5929070...6511107. Read the comment docs.

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9046261 into master Apr 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-syntax-issues branch April 28, 2021 14:54
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 28, 2021
This was referenced Jan 18, 2022
Merged
Closed
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

+1 more reviewer

@software-dov software-dov software-dov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple syntax issues with latest generator release 0.44.0

3 participants

@busunkim96 @software-dov @parthea