Skip to content

feat: [tpu] make reservation_name parameter generally visible in QueuedResource message #9353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

feat: [tpu] make reservation_name parameter generally visible in QueuedResource message #9353

merged 2 commits into from
Apr 25, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Apr 14, 2023 •
edited
Loading

  • Regenerate this pull request now.

feat: add DeleteQueuedResource experiment

docs(v2alpha1): minor formatting to the description for queued_resource_id

PiperOrigin-RevId: 524336094

Source-Link: googleapis/googleapis@cad90d2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/848f9c294076db6d1d1a78013040251b1c0ad7a9
Copy-Tag: eyJwIjoiamF2YS10cHUvLk93bEJvdC55YW1sIiwiaCI6Ijg0OGY5YzI5NDA3NmRiNmQxZDFhNzgwMTMwNDAyNTFiMWMwYWQ3YTkifQ==

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@snippet-bot
Copy link

snippet-bot bot commented Apr 14, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@emmileaf
Copy link
Contributor

I think the generation_diff presubmit failures can be resolved by pulling in changes from #9357. Going to trigger re-generation for this PR.

diff --git a/java-maps-routing/google-maps-routing-bom/pom.xml b/java-maps-routing/google-maps-routing-bom/pom.xml
index de4298e39..b1d470e69 100644
--- a/java-maps-routing/google-maps-routing-bom/pom.xml
+++ b/java-maps-routing/google-maps-routing-bom/pom.xml
@@ -3,[7](https://github.com/googleapis/google-cloud-java/actions/runs/4704311118/jobs/8343818522?pr=9353#step:5:8) +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.google.maps</groupId>
   <artifactId>google-maps-routing-bom</artifactId>
-  <version>1.0.0</version><!-- {x-version-update:google-maps-routing:current} -->
+  <version>1.0.1-SNAPSHOT</version><!-- {x-version-update:google-maps-routing:current} -->
   <packaging>pom</packaging>

@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Apr 25, 2023

Owl bot is regenerating pull request 9353...
Build name: MWU1MWRjZjUtNmJkZi00ZmJiLTg5YzYtMDhjMjBkOWQyYzgz

@gcf-owl-bot
feat: make reservation_name parameter generally visible in QueuedReso…
5c10daa 
…urce message

---
feat: add DeleteQueuedResource experiment

---
docs(v2alpha1): minor formatting to the description for `queued_resource_id`

PiperOrigin-RevId: 524336094

Source-Link: googleapis/googleapis@cad90d2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/848f9c294076db6d1d1a78013040251b1c0ad7a9
Copy-Tag: eyJwIjoiamF2YS10cHUvLk93bEJvdC55YW1sIiwiaCI6Ijg0OGY5YzI5NDA3NmRiNmQxZDFhNzgwMTMwNDAyNTFiMWMwYWQ3YTkifQ==
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-tpu branch from a9d2b7e to 5c10daa Compare April 25, 2023 18:51
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@emmileaf emmileaf merged commit fd4b098 into main Apr 25, 2023
@emmileaf emmileaf deleted the owl-bot-copy-java-tpu branch April 25, 2023 20:01
@release-please release-please bot mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emmileaf emmileaf emmileaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmileaf @yoshi-kokoro