Skip to content

feat: Enable webauthn plugin for security keys #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 6, 2024
Merged

feat: Enable webauthn plugin for security keys #1528

merged 10 commits into from
Jun 6, 2024

Conversation

cpisunyer
Copy link
Contributor

Following up on the earlier PR from ikimonogakari, this code will route security key requests to the webauthn plugin if the GOOGLE_AUTH_WEBAUTHN_PLUGIN env variable is set. If the variable is not set, the existing code path continues to be executed.

@cpisunyer cpisunyer requested review from a team as code owners May 30, 2024 22:22
@cpisunyer cpisunyer changed the title Enable webauthn plugin for security keys feat: Enable webauthn plugin for security keys May 31, 2024
@arithmetic1728
Copy link
Contributor

@ikimonogakari could you take a look as well? Thanks!

ikimonogakari
ikimonogakari approved these changes Jun 5, 2024
View reviewed changes
@cpisunyer
feat: Enable webauthn plugin for security keys
9dad18c 
Move key press prompt and remove TODO question.
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2024
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2024
sai-sunder-s
sai-sunder-s reviewed Jun 5, 2024
View reviewed changes
clundin25
clundin25 reviewed Jun 5, 2024
View reviewed changes
clundin25
clundin25 reviewed Jun 5, 2024
View reviewed changes
clundin25
clundin25 reviewed Jun 5, 2024
View reviewed changes
clundin25
clundin25 reviewed Jun 5, 2024
View reviewed changes
clundin25
clundin25 reviewed Jun 5, 2024
View reviewed changes