Skip to content

[DevExperience]: Inconsistency in time related field types #2645

@zombieleet

Description

@zombieleet

I am currently working with go-github sdk, and I noticed some inconsistencies in the types of time fields. Some fields are *time.Time while others are *Timestamp.

For example, this difference can be spotted in the PullRequest and Projects struct. It is also littered around the codebase. In my opinion, let's stick to one type for time fields which is *Timestamp.

if this is seen as a valid issue, I will open a PR to fix it.

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions