Add support for GTest based unit tests. #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Dominic and I have previously discussed, there is some need/desire to improve the testing situation in Google Benchmark. One step to fixing this problem is to make it easier to write unit tests by adding support for GTest, which is what this patch does. By default it looks for an installed version of GTest. However the user can specify -DBENCHMARK_BUILD_EXTERNAL_GTEST=ON to instead download, build, and use copy of gtest from source. This is quite useful when Benchmark is being built in non-standard configurations, such as against libc++ or in 32 bit mode.
|
❌ Build benchmark 848 failed (commit 6cd3b8eda5 by @EricWF) |
LebedevRI
reviewed
Nov 25, 2017
cmake/HandleGTest.cmake
Outdated
| add_library(gtest UNKNOWN IMPORTED) | ||
| add_library(gtest_main UNKNOWN IMPORTED) | ||
| set_target_properties(gtest PROPERTIES | ||
| IMPORTED_LOCATION ${install_dir}/lib/libgtest.a |
There was a problem hiding this comment.
+ INTERFACE_SYSTEM_INCLUDE_DIRECTORIES ${CMAKE_BINARY_DIR}/googletest/include
LebedevRI
reviewed
Nov 25, 2017
cmake/HandleGTest.cmake
Outdated
| IMPORTED_LOCATION ${install_dir}/lib/libgtest.a | ||
| ) | ||
| set_target_properties(gtest_main PROPERTIES | ||
| IMPORTED_LOCATION ${install_dir}/lib/libgtest_main.a |
There was a problem hiding this comment.
As Dominic and I have previously discussed, there is some
need/desire to improve the testing situation in Google Benchmark.
One step to fixing this problem is to make it easier to write
unit tests by adding support for GTest, which is what this patch does.
By default it looks for an installed version of GTest. However the
user can specify -DBENCHMARK_BUILD_EXTERNAL_GTEST=ON to instead
download, build, and use copy of gtest from source. This is
quite useful when Benchmark is being built in non-standard configurations,
such as against libc++ or in 32 bit mode.