Merge pull request #483 from i25959341/patch-1

asciimoo · web-flow · commit f9898dc04423 · 2020-05-11T00:59:27.000+02:00
Proxy accessing array in a not thread safe way
diff --git a/proxy/proxy.go b/proxy/proxy.go
@@ -29,8 +29,9 @@ type roundRobinSwitcher struct {
 }
 
 func (r *roundRobinSwitcher) GetProxy(pr *http.Request) (*url.URL, error) {
-	u := r.proxyURLs[r.index%uint32(len(r.proxyURLs))]
-	atomic.AddUint32(&r.index, 1)
+	index := atomic.AddUint32(&r.index, 1) - 1
+	u := r.proxyURL[index%uint32(len(r.proxyURLs))]
+	
 	ctx := context.WithValue(pr.Context(), colly.ProxyURLKey, u.String())
 	*pr = *pr.WithContext(ctx)
 	return u, nil
