fix: #logo image wider than email container #5284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5284 +/- ##
=======================================
Coverage 29.89% 29.89%
=======================================
Files 231 231
Lines 19138 19138
Branches 2736 2736
=======================================
Hits 5721 5721
Misses 13178 13178
Partials 239 239Continue to review full report at Codecov.
|
Contributor
|
Hey @sebastiantf thanks for this - how did you test your fix here? Do you have any screenshots? |
Contributor
|
speaking of testing; id be interested to know if this introduces any regressions too |
Contributor
Author
|
@danlipert, I was testing it using Chrome DevTools to apply the style and it looked good. I shall now try the instructions by @owocki to generate an email with the new styles and post a screenshot asap. @owocki I shall check and see if this update brings back any other issues. |
octavioamu
approved these changes
Oct 2, 2019
thelostone-mc
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue of the header logo image being wider than the email container
Refers/Fixes
Fixes #5271
Testing