reset.c: enable fscache #1427
Merged
reset.c: enable fscache #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In git reset --hard, unpack-trees() is called with oneway_merge(). oneway_merge calls lstat for each files in a repository. It is bottleneck of git reset --hard, especially in large repository. This patch improves time by using fscache. In chromium repository, time of git reset --hard is changed like below. I took 3 times stats in the repository. master: TotalSeconds: 21.0337971 TotalSeconds: 20.0046612 TotalSeconds: 20.6501752 Avg: 20.5628778333333 this patch: TotalSeconds: 4.8552376 TotalSeconds: 4.8722343 TotalSeconds: 4.9268245 Avg: 4.88476546666667 Signed-off-by: Takuto Ikuta <[email protected]>
Member
|
Thank you very much! |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Jan 17, 2018
With lots of files, `git reset --hard` [is now a lot faster](git-for-windows/git#1427) when the FSCache feature is in effect. Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 20, 2018
reset.c: enable fscache
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2018
reset.c: enable fscache
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2018
reset.c: enable fscache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In git reset --hard, unpack-trees() is called with oneway_merge().
oneway_merge calls lstat for each files in a repository.
It is bottleneck of git reset --hard, especially in large repository.
This patch improves time by using fscache.
In chromium repository, time of git reset --hard is changed like below.
I took 3 times stats in the repository.
master:
TotalSeconds: 21.0337971
TotalSeconds: 20.0046612
TotalSeconds: 20.6501752
Avg: 20.5628778333333
this patch:
TotalSeconds: 4.8552376
TotalSeconds: 4.8722343
TotalSeconds: 4.9268245
Avg: 4.88476546666667
Signed-off-by: Takuto Ikuta [email protected]