v1.2 #871
Merged
v1.2 #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`reset` field should be after `method` in LoggerWithWriter function.
Make CreateTestContext public without importing net/http/httptest
Remove an obsolete func in README
Fix log color reset
Move golang.org/x/net/context.Context interface implementation check to tests
Context.Get() does not need to test whether Keys is nil or not
Gin normally silently swallows errors writing to the client; however in WriteJSON (and thus context.JSON), the ResponseWriter was being passed directly into the JSON encoder, which will return an error if there's an error writing to the stream. For instance, context.JSON would panic with errors like "write tcp XXX-> YYY: write: connection reset by peer" if the client disconnected before the response was complete. This change makes JSON.Render() treat write errors the same as IndentedJSON, Data, and other renderers.
Signed-off-by: Bo-Yi Wu <[email protected]>
Signed-off-by: Bo-Yi Wu <[email protected]>
Support disable console color
Signed-off-by: Bo-Yi Wu <[email protected]>
Signed-off-by: Bo-Yi Wu <[email protected]>
Support upload single or multiple files.
Improve document for #742
* Add convenience method to check if websockets required * Add tests * Fix up tests for develop branch
Signed-off-by: Bo-Yi Wu <[email protected]>
Add comment for the logic behind func.
This reverts commit 5379977.
feat(context): add idiomatic binding functions for clear err managment
Signed-off-by: Bo-Yi Wu <[email protected]>
Signed-off-by: Bo-Yi Wu <[email protected]>
* Improve debug.go code coverage * lint code
Made funMaps for the templates configurable and hot-reloadable
copied from gin_test.go @appleboy commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
gin.goREADMEfrom gopkg.in to GitHub.com