Skip to content

feat(context): add idiomatic binding functions for clear err managment #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2017
Merged

feat(context): add idiomatic binding functions for clear err managment #855

merged 1 commit into from
Jun 27, 2017

Conversation

@javierprovecho
Copy link
Member

@javierprovecho javierprovecho commented Mar 29, 2017

fix #662

@javierprovecho javierprovecho requested a review from appleboy March 29, 2017 14:33
@javierprovecho
Copy link
Member Author

javierprovecho commented Mar 29, 2017

@appleboy I'm not sure what to do with BindJSON and others, they use BindWith which now uses MustBindWith...

@codecov-io
Copy link

codecov-io commented Mar 29, 2017 •
edited
Loading

Codecov Report

Merging #855 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #855      +/-   ##
===========================================
+ Coverage    93.48%   93.51%   +0.03%     
===========================================
  Files           16       16              
  Lines         1351     1358       +7     
===========================================
+ Hits          1263     1270       +7     
  Misses          78       78              
  Partials        10       10
Impacted Files Coverage Δ
context.go 89.41% <100%> (+0.03%) ⬆️
deprecated.go 66.66% <100%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2dace...73e5fcd. Read the comment docs.

@appleboy
Copy link
Member

appleboy commented Mar 30, 2017

if we merge #636 PR, we can ignore this PR. right?

@javierprovecho javierprovecho modified the milestone: 1.2 Apr 17, 2017
@javierprovecho
Copy link
Member Author

javierprovecho commented Jun 27, 2017

@appleboy if 636 is merged, some behavior may be broken. this pr is the way to go, by using deprecated.go and a warning print for those who use bindwith

@javierprovecho javierprovecho merged commit 1a9cba2 into develop Jun 27, 2017
@javierprovecho javierprovecho mentioned this pull request Jun 27, 2017
Closed
This was referenced Jun 28, 2017
Open
Closed
@sidbusy
Copy link

sidbusy commented Jun 28, 2017

@javierprovecho Nice! Pls release new version ASAP, Thx!

@appleboy appleboy deleted the feat/662 branch June 28, 2017 02:09
@appleboy
Copy link
Member

appleboy commented Jun 28, 2017

@sidbusy Yes. he is working on #871 v1.2 release.

@appleboy appleboy mentioned this pull request Jun 30, 2017
Open
@javierprovecho javierprovecho mentioned this pull request Jul 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appleboy appleboy Awaiting requested review from appleboy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

5 participants

@javierprovecho @codecov-io @appleboy @sidbusy