fix #752 ignore appengine os. #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bo-Yi Wu <[email protected]>
Contributor
|
And why do you also ignore bsd? |
Member
|
I also use Google App Engine and I have the same issue #752 than @kujenga: I have temporarily fixed it by checking out the bb159f9 commit, but can you try to fix this problem? |
Member
|
@javierprovecho No worries, thanks a lot for the fix! |
Member
Author
appleboy
pushed a commit
that referenced
this pull request
Feb 1, 2017
appleboy
pushed a commit
that referenced
this pull request
May 29, 2017
* Revert "Merge pull request #753 from gin-gonic/bug" This reverts commit 556287f, reversing changes made to 32cab50. * Revert "Merge pull request #744 from aviddiviner/logger-fix" This reverts commit c3bfd69, reversing changes made to 9177f01. * add custom Delims support * add some test for Delims * remove the empty line for import native package * remove unuseful comments
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
critical issue #752
Please help to review.
cc @javierprovecho @tboerger
Signed-off-by: Bo-Yi Wu [email protected]