Skip to content

feat(form): Support default values for collections in form binding #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2024
Merged

feat(form): Support default values for collections in form binding #4048

merged 1 commit into from
Sep 21, 2024

Conversation

@takanuva15
Copy link
Contributor

@takanuva15 takanuva15 commented Sep 3, 2024 •
edited
Loading

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

This PR adds support for default values for the "multi" and "csv" collection_format binding types introduced in PR #3986.

closes #2744

@takanuva15 takanuva15 force-pushed the master branch 3 times, most recently from 9ef9fbb to 5fb3ad0 Compare September 3, 2024 13:20
@takanuva15
Copy link
Contributor Author

@appleboy this PR is related to the PR #3986 you merged last month

@appleboy appleboy added this to the v1.11 milestone Sep 6, 2024
@takanuva15
Copy link
Contributor Author

@appleboy updated the PR and fixed the issue with golangci-lint

@codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (3dc1cd6) to head (edba6c2).
Report is 72 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4048      +/-   ##
==========================================
- Coverage   99.21%   99.07%   -0.14%     
==========================================
  Files          42       44       +2     
  Lines        3182     2811     -371     
==========================================
- Hits         3157     2785     -372     
+ Misses         17       15       -2     
- Partials        8       11       +3
Flag Coverage Δ
?
-tags "sonic avx" 99.06% <100.00%> (?)
-tags go_json 99.06% <100.00%> (?)
-tags nomsgpack 99.06% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 99.07% <100.00%> (-0.14%) ⬇️
go-1.22 99.07% <100.00%> (?)
macos-latest 99.07% <100.00%> (-0.14%) ⬇️
ubuntu-latest 99.07% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takanuva15
Copy link
Contributor Author

@appleboy updated the PR to fix the test coverage issue

@takanuva15
Copy link
Contributor Author

@appleboy I don't know how else to increase coverage since all of my code is 100% covered - the "codecov/patch" says codecov/patch — 100.00% of diff hit (target 99.21%)

image

I saw that you approved this other PR 2 weeks ago with worse project coverage than my PR, so it looks like my PR is actually making the overall coverage better than it was previously.
image

If there's no other issue, I hope you can approve it?

@appleboy appleboy merged commit f05f966 into gin-gonic:master Sep 21, 2024
@takanuva15 takanuva15 mentioned this pull request Jan 16, 2025
Open
1911860538 pushed a commit to 1911860538/gin that referenced this pull request Feb 26, 2025
@takanuva15
feat(form): Support default values for collections in form binding (g…
a5fcac4 
…in-gonic#4048)
@yashuatla yashuatla mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appleboy appleboy appleboy approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

2 participants

@takanuva15 @appleboy