Format target value as a number with reasonable default (#4073)

arikfr · web-flow · commit 24d68008fa5d · 2019-08-15T15:54:32.000+03:00
diff --git a/client/app/visualizations/counter/index.js b/client/app/visualizations/counter/index.js
@@ -145,8 +145,13 @@ const CounterRenderer = {
         $scope.targetValueTooltip = formatTooltip($scope.targetValue, options.tooltipFormat);
 
         $scope.counterValue = formatValue($scope.counterValue, options);
+
         if (options.formatTargetValue) {
           $scope.targetValue = formatValue($scope.targetValue, options);
+        } else {
+          if (Number.isFinite($scope.targetValue)) {
+            $scope.targetValue = numeral($scope.targetValue).format('0[.]00[0]');
+          }
         }
       }
 

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,13 @@ const CounterRenderer = {`
`145`	`145`	`$scope.targetValueTooltip = formatTooltip($scope.targetValue, options.tooltipFormat);`
`146`	`146`
`147`	`147`	`$scope.counterValue = formatValue($scope.counterValue, options);`
	`148`	`+`
`148`	`149`	`if (options.formatTargetValue) {`
`149`	`150`	`$scope.targetValue = formatValue($scope.targetValue, options);`
	`151`	`+ } else {`
	`152`	`+ if (Number.isFinite($scope.targetValue)) {`
	`153`	`+ $scope.targetValue = numeral($scope.targetValue).format('0[.]00[0]');`
	`154`	`+ }`
`150`	`155`	`}`
`151`	`156`	`}`
`152`	`157`