Skip to content

fix: reduce entry padding when selecting content for sharing #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2025
Merged

fix: reduce entry padding when selecting content for sharing #121

merged 3 commits into from
Oct 8, 2025

Conversation

@addresskrish
Copy link
Contributor

Description

Reduces excessive padding in the content picker window to provide more space for content previews while maintaining clean spacing.

Changes Made

  • Reduce container padding from px-4 to px-2 for more content space
  • Reduce individual item padding from p-2 to p-1
  • Reduce gaps between items from gap-4 to gap-3
  • Remove unnecessary margin from title text
  • Reduce padding in resolution selector and accessibility warning areas

Impact

  • Content previews are now larger and easier to see
  • Better space utilization while maintaining visual hierarchy
  • Improved user experience for screen sharing selection

Testing

  • Code compiles without errors
  • Changes maintain existing functionality
  • Responsive design preserved
  • No accessibility issues introduced

Fixes #114

@addresskrish
fix: reduce entry padding when selecting content for sharing
7b2bee4 
- Reduce container padding from px-4 to px-2 for more content space
- Reduce individual item padding from p-2 to p-1
- Reduce gaps between items from gap-4 to gap-3
- Remove unnecessary margin from title text
- Reduce padding in resolution selector and accessibility warning areas

This provides more space for content previews while maintaining clean spacing.

Fixes gethopp#114
@addresskrish addresskrish requested a review from konsalex as a code owner October 5, 2025 15:43
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 5, 2025 •
edited
Loading

✅ Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit 8859515
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/68e5930fda075900083382a4
😎 Deploy Preview https://deploy-preview-121--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

iparaskev
iparaskev requested changes Oct 6, 2025
View reviewed changes
@addresskrish
fix: add items-start to prevent grid items from stretching
35fb294 
Address reviewer feedback to stop grid items from stretching by adding
items-start class to the grid container.
iparaskev
iparaskev requested changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@iparaskev iparaskev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep only the items-start change. Everything else should be the same.

@iparaskev iparaskev merged commit 1ac9b45 into gethopp:main Oct 8, 2025
14 checks passed
@iparaskev
Copy link
Contributor

@addresskrish thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iparaskev iparaskev iparaskev approved these changes

@konsalex konsalex Awaiting requested review from konsalex konsalex is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

design: reduce entry padding when selecting content for sharing

3 participants

@addresskrish @CLAassistant @iparaskev