Fix identify #61
Merged
Fix identify #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-1198 Empty address for identify calls
We stopped getting addresses in identify calls since the last SDK release |
TamHuynhTee
reviewed
Apr 22, 2025
| providerName?: string; | ||
| userId?: string; | ||
| rdns?: string; | ||
| }): Promise<void>; |
Collaborator
There was a problem hiding this comment.
properties?: IFormoEventProperties,
context?: IFormoEventContext,
callback?: (...args: unknown[]) => void
why r u removing these ?
Contributor
Author
There was a problem hiding this comment.
Mistake, let me add it back
yosriady
commented
Apr 22, 2025
| }; | ||
|
|
||
| // TODO: enable this | ||
| // this.currentAddress = address; |
Contributor
Author
There was a problem hiding this comment.
If an address is set by a previous identify or connect event, all subsequent events should have it
yosriady
commented
Apr 22, 2025
|
|
||
| // TODO: enable this | ||
| // this.currentAddress = address; | ||
| // if (userId) this.userId = userId || null; |
Contributor
Author
There was a problem hiding this comment.
If a userId is set by a previous identify or connect event, all subsequent events should have it
TamHuynhTee
approved these changes
Apr 22, 2025
TamHuynhTee
added a commit
that referenced
this pull request
Apr 23, 2025
* Update SDK to follow 2.0 event spec * Refactor * Refactor * Refactor * Add Track event type * refactor with switch case * Remove comment, refactor * Add version generator, rename event type, change event endpoint * Refactor Event Factory, receive additional properties, context, callback as parameters * Fix identify (#61) * Fix identify * Fix merge * Fix interface * Define generateMessageId helper function * Rename timestamp to originalTimestamp * Add sent_at * Generate sent_at once for the entire batch * Update EVENTS_API_URL * Add user id tracking property, pass user id and address as optional parameters if they're set --------- Co-authored-by: Huỳnh Thanh Tâm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify can no longer autodetect addresses, only an explicit connect event can get it now.
This PR simplifies the
identifyfunction