Twitter labels updated to 'X' #2914

akzmoudud · 2025-09-19T10:12:08Z

All Submissions:

My code follow the WordPress' coding standards
My code satisfies feature requirements
My code is tested
My code passes the PHPCS tests
My code has proper inline documentation
I've included related pull request(s) (optional)
I've included developer documentation (optional)
I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

Full PR Link
https://github.com/getdokan/dokan-pro/pull/4531

Closes

Closes https://github.com/getdokan/dokan-pro/issues/4502

How to test the changes in this Pull Request:

Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

Code is not following code style guidelines
Bad naming: make sure you would understand your code if you read it a few months from now.
KISS: Keep it simple, Sweetie (not stupid!).
DRY: Don't Repeat Yourself.
Code that is not readable: too many nested 'if's are a bad sign.
Performance issues
Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
Readable — Will your future self be able to understand this change months down the road?
Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

Chores
- Updated the social profile label from “Twitter” to “X” across the admin Vendor Social Fields UI, vendor settings, and personal data export.
- Adjusted translations to reflect the new label; field identifiers and data structures remain unchanged.
- Ensures consistent naming in all user-facing areas without impacting functionality or existing vendor data.

coderabbitai · 2025-09-19T10:12:18Z

Walkthrough

Changed the vendor social field label from “Twitter” to “X” across backend export (privacy), social profile fields, and the admin UI. No data structures, logic, or signatures were modified. Input keys and models remain “twitter”; only the displayed/translated label text changed.

Changes

Cohort / File(s)	Summary
Privacy export label `includes/Privacy.php`	Updated vendor personal data export social field label from "Twitter" to "X".
Social profile fields (PHP) `includes/functions.php`	Changed social profile field label from "Twitter" to "X" in `dokan_get_social_profile_fields`.
Admin UI vendor social fields (Vue) `src/admin/pages/VendorSocialFields.vue`	Renamed displayed label from "Twitter" to "X"; kept input id and model as "twitter".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my whiskers, hop with glee,
A tiny X replaces T, so neatly, tidily.
Labels refreshed, the fields still flow,
Same keys below, new names to show.
In carrot code and midnight hex,
We ship a squeak: goodbye Twitter—hello X! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description follows the template structure but is largely incomplete with multiple critical sections missing content. The "Changes proposed in this Pull Request" section is empty (containing only HTML comments), the "How to test the changes" section lacks concrete testing steps, and the "Changelog entry", "Before Changes", and "After Changes" sections contain only placeholder text. While related PR and issue links are provided, the description fails to deliver essential details about the actual changes made, their rationale, and how reviewers should verify the modifications.	The author should fill in all empty sections with meaningful content: (1) explicitly describe what changes were made and why Twitter labels were updated to 'X' in the "Changes proposed" section, (2) provide concrete steps or instructions on how to test the changes (e.g., where to verify the label updates in the UI), (3) complete the changelog entry describing the previous behavior versus new behavior, (4) include before and after screenshots or descriptions, and (5) mark completed checklist items appropriately to reflect the actual work done.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title Check	✅ Passed	The title "Twitter labels updated to 'X'" clearly and concisely describes the main change across all modified files. It accurately reflects that Twitter field labels are being updated to display 'X' instead of 'Twitter' in multiple locations (includes/Privacy.php, includes/functions.php, and src/admin/pages/VendorSocialFields.vue). The title is specific and provides sufficient context for understanding the primary modification.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch enhancement/store-seo-twitter-labels-changed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

includes/Privacy.php (1)
200-208: Add translator context for "X" (formerly Twitter) and regenerate POT/PO.

Replace all __("X", "dokan-lite") uses with _x("X", "social network name (formerly Twitter)", "dokan-lite") and add a translators comment so exported labels aren't mistranslated.

Locations:

includes/Privacy.php (around lines 200-202)

includes/functions.php (around line 2287)

Suggested diffs:
-                    'twitter'   => __( 'X', 'dokan-lite' ),
+                    /* translators: Social network name (formerly Twitter). */
+                    'twitter'   => _x( 'X', 'social network name (formerly Twitter)', 'dokan-lite' ),
-            'title' => __( 'X', 'dokan-lite' ),
+            /* translators: Social network name (formerly Twitter). */
+            'title' => _x( 'X', 'social network name (formerly Twitter)', 'dokan-lite' ),
Regenerate POT/PO so translators receive the new string/context.

🧹 Nitpick comments (1)

src/admin/pages/VendorSocialFields.vue (1)
20-23: LGTM; optional UX clarity.

Label change is consistent. Optionally show “X (Twitter)” to aid recognition.
-                    <label for="twitter">{{ __( 'X', 'dokan-lite' ) }}</label>
+                    <label for="twitter">{{ __( 'X (Twitter)', 'dokan-lite' ) }}</label>

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13cf39c and 72be37e.

📒 Files selected for processing (3)

includes/Privacy.php (1 hunks)
includes/functions.php (1 hunks)
src/admin/pages/VendorSocialFields.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: e2e tests (2, 3)
GitHub Check: api tests (1, 1)
GitHub Check: e2e tests (3, 3)
GitHub Check: e2e tests (1, 3)

🔇 Additional comments (1)

includes/functions.php (1)
2285-2288: Add translator context for "X" (formerly Twitter) and verify Font Awesome icon

Replace plain __('X', 'dokan-lite') with a contexted _x and translators comment; apply across the codebase. Example diff for includes/functions.php:
         'twitter'   => [
             'icon'  => 'fa-brands fa-square-x-twitter',
-            'title' => __( 'X', 'dokan-lite' ),
+            /* translators: Social network name (formerly Twitter). */
+            'title' => _x( 'X', 'social network name (formerly Twitter)', 'dokan-lite' ),
         ],
Update all occurrences found: includes/functions.php (2286), includes/Privacy.php (202), src/admin/pages/VendorSocialFields.vue (21), tests/pw/pages/selectors.ts (7618), and ensure translation usage is consistent in any other files.

Confirm fa-square-x-twitter is provided by your Font Awesome integration (CDN/package/WordPress admin). If not supported, replace or fallback (e.g., fa-twitter) and make icon classes consistent (VendorSingle.vue currently uses fa-twitter).

Twitter labels updated to 'X'

72be37e

akzmoudud self-assigned this Sep 19, 2025

akzmoudud added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Sep 19, 2025

coderabbitai bot reviewed Sep 19, 2025

View reviewed changes

mrabbani approved these changes Oct 21, 2025

View reviewed changes

mrabbani added Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Oct 21, 2025

dev-shahed added 🎉 QA Approved This PR is approved by the QA team and removed Needs: Testing This requires further testing labels Oct 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Twitter labels updated to 'X' #2914

Twitter labels updated to 'X' #2914

Uh oh!

akzmoudud commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Twitter labels updated to 'X' #2914

Are you sure you want to change the base?

Twitter labels updated to 'X' #2914

Uh oh!

Conversation

akzmoudud commented Sep 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

Changelog entry

Before Changes

After Changes

Feature Video (optional)

PR Self Review Checklist:

FOR PR REVIEWER ONLY:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

akzmoudud commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 19, 2025 •

edited

Loading