Skip to content

Reduce redundancy in auto send preference migration code #1133

@lognaturel

Description

@lognaturel

Between version 1.7.1 and future versions, the auto send setting was collapsed from two settings (send over wifi or send over cellular) to a single one with a string value. This required making sure that the setting value would be migrated when doing an update, when using collect.settings files from versions <=1.7.1 and when using json/QR codes from <=1.7.1. There will likely be other such changes to settings in the future.

Currently the migration code is in three separate places. It would be good to have it in a single place. One approach could be to read the collect.settings or QR code settings as they are including the old wifi and cellular settings and then change them after they have been imported as settings.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions