feat: abstract clone method

gajus · gajus · commit faeabee61e9e · 2018-05-08T16:58:33.000+01:00
diff --git a/src/evaluators/browserEvaluator.js b/src/evaluators/browserEvaluator.js
@@ -52,7 +52,13 @@ export default (): EvaluatorType => {
     throw new Error('Unimplemented.');
   };
 
+  // eslint-disable-next-line no-unused-vars
+  const clone = (node) => {
+    throw new Error('Unimplemented.');
+  };
+
   return {
+    clone,
     getAttributeValue,
     getPropertyValue,
     isElement,
diff --git a/src/evaluators/cheerioEvaluator.js b/src/evaluators/cheerioEvaluator.js
@@ -79,7 +79,12 @@ export default (): EvaluatorType => {
     node.remove();
   };
 
+  const clone = (node) => {
+    return node.clone();
+  };
+
   return {
+    clone,
     getAttributeValue,
     getPropertyValue,
     isElement,
diff --git a/src/subroutines/removeSubroutine.js b/src/subroutines/removeSubroutine.js
@@ -9,17 +9,24 @@ import {
 import type {
   SubroutineType
 } from '../types';
+import {
+  SurgeonError
+} from '../errors';
 import selectSubroutine from './selectSubroutine';
 
 const debug = createDebug('subroutine:remove');
 
-const removeSubroutine: SubroutineType = (inputSubject, [cssSelector, quantifierExpression], {evaluator}) => {
+const removeSubroutine: SubroutineType = (subject, [cssSelector, quantifierExpression], {evaluator}) => {
   debug('selecting "%s" for removal', cssSelector);
 
+  if (!evaluator.isElement(subject)) {
+    throw new SurgeonError('Unexpected value. Value must be an element.');
+  }
+
   // Ensure that we do not mutate the parent node.
-  const subject = inputSubject.clone();
+  const cloneSubject = evaluator.clone(subject);
 
-  const matches = selectSubroutine(subject, [cssSelector, quantifierExpression], {evaluator});
+  const matches = selectSubroutine(cloneSubject, [cssSelector, quantifierExpression], {evaluator});
 
   if (Array.isArray(matches)) {
     for (const match of matches) {
@@ -29,7 +36,7 @@ const removeSubroutine: SubroutineType = (inputSubject, [cssSelector, quantifier
     evaluator.remove(matches);
   }
 
-  return subject;
+  return cloneSubject;
 };
 
 export default removeSubroutine;
diff --git a/src/types.js b/src/types.js
@@ -7,6 +7,7 @@ type ElementType = Object;
 type BindleType = Object;
 
 export type EvaluatorType = {|
+  +clone: (element: ElementType) => ElementType,
   +getAttributeValue: (element: ElementType, name: string) => string,
   +getPropertyValue: (element: ElementType, name: string) => mixed,
   +isElement: (maybeElement: mixed) => boolean,
