feat: added spline functionality #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmmishra
suggested changes
Aug 29, 2019
scmmishra
suggested changes
Aug 29, 2019
Contributor
|
Hey @nniclas great work with the PR. Hope to merge it soon and release it, I've made a few suggestions, mostly regarding style please refer the thread for the same. |
Co-Authored-By: Shivam Mishra <[email protected]>
Contributor
Author
|
Sure, I'd be happy to contribute, the library is great. Suggestions are good. |
scmmishra
approved these changes
Sep 2, 2019
This was referenced Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation About What Code Achieves:
Spline option added to line chart.
createSplineCurve() added to draw utils, returns an svg path string from xy lists.
Screenshots/GIFs:
Steps To Test:
Add a line chart and configure option with: lineOptions: { spline: true }
TODOs: